Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix "Conditional is marked as unsafe, and cannot be evaluated." #4024

Merged
merged 1 commit into from
Jan 20, 2024

Conversation

tchernomax
Copy link
Contributor

Description: ansible: fix the assert call on ansible 2.16.1 and 2.14.2

https://docs.ansible.com/ansible-core/2.16/porting_guides/porting_guide_core_2.16.html#playbook

fix error "Conditional is marked as unsafe, and cannot be evaluated." when splunk_access_token come from an untrusted source (like a lookup).

Testing: none

Documentation: none

@tchernomax tchernomax requested review from a team as code owners December 6, 2023 15:57
Copy link
Contributor

github-actions bot commented Dec 6, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@tchernomax
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@tchernomax
Copy link
Contributor Author

recheck

srv-gh-o11y-gdi-cla added a commit to splunk/cla-agreement that referenced this pull request Dec 6, 2023
@atoulme
Copy link
Contributor

atoulme commented Dec 7, 2023

Changes look good, we need to navigate the CI failures. We will work through them.

@Akivas
Copy link

Akivas commented Jan 18, 2024

Hello o/
Any news on this issue ? :)

Thanks !

@pjanotti pjanotti merged commit f22d94b into signalfx:main Jan 20, 2024
61 of 80 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants